Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade clap to 3.0.0 #1261

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Upgrade clap to 3.0.0 #1261

merged 1 commit into from
Feb 3, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Feb 2, 2022 •
edited
Loading

Which issue does this PR close?

Closes #1260

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

parquet-read

❯ cargo run --features=cli -q --bin parquet-read -- -h
parquet 8.0.0
Apache Arrow <[email protected]>
Binary file to read data from a Parquet file

USAGE:
    parquet-read [OPTIONS] --file-name <FILE_NAME>

OPTIONS:
    -f, --file-name <FILE_NAME>        Path to a parquet file
    -h, --help                         Print help information
    -j, --json                         Print Parquet file in JSON lines format
    -n, --num-records <NUM_RECORDS>    Number of records to read. When not provided or 0, all
                                       records are read [default: 0]
    -V, --version                      Print version information

parquet-rowcount

❯ cargo run --features=cli -q --bin parquet-rowcount -- -h
parquet 8.0.0
Apache Arrow <[email protected]>
Binary file to return the number of rows found from Parquet file(s)

USAGE:
    parquet-rowcount [OPTIONS]

OPTIONS:
    -f, --file-paths <FILE_PATHS>...    List of Parquet files to read from separated by space
    -h, --help                          Print help information
    -V, --version                       Print version information

parquet-schema

❯ cargo run --features=cli -q --bin parquet-schema -- -h
parquet 8.0.0
Apache Arrow <[email protected]>
Binary file to print the schema and metadata of a Parquet file

USAGE:
    parquet-schema [OPTIONS] --file-path <FILE_PATH>

OPTIONS:
    -f, --file-path <FILE_PATH>
    -h, --help                     Print help information
    -v, --verbose                  Enable printing full file metadata
    -V, --version                  Print version information

arrow-file-to-stream

❯ cargo run --features=cli -q --bin arrow-file-to-stream -- -h
arrow-integration-testing 8.0.0
Apache Arrow <[email protected]>
Read an arrow file and stream to stdout

USAGE:
    arrow-file-to-stream --file-name <FILE_NAME>

OPTIONS:
    -f, --file-name <FILE_NAME>
    -h, --help                     Print help information
    -V, --version                  Print version information

arrow-json-integration-test

❯ cargo run --features=cli -q --bin arrow-json-integration-test -- -h
arrow-integration-testing 8.0.0
Apache Arrow <[email protected]>
rust arrow-json-integration-test

USAGE:
    arrow-json-integration-test [OPTIONS] --integration <INTEGRATION> --arrow <ARROW> --json <JSON>

OPTIONS:
    -a, --arrow <ARROW>                path to ARROW file
    -h, --help                         Print help information
    -i, --integration <INTEGRATION>    integration
    -j, --json <JSON>                  path to JSON file
    -m, --mode <MODE>                  mode of integration testing tool [default: validate]
                                       [possible values: arrow-to-json, json-to-arrow, validate]
    -v, --verbose
    -V, --version                      Print version information

flight-test-integration-client

❯ cargo run --features=cli -q --bin flight-test-integration-client -- -h
arrow-integration-testing 8.0.0
Apache Arrow <[email protected]>
rust flight-test-integration-client

USAGE:
    flight-test-integration-client [OPTIONS] --host <HOST> --port <PORT> --path <PATH>

OPTIONS:
    -h, --help                   Print help information
        --host <HOST>
        --path <PATH>
        --port <PORT>
        --scenario <SCENARIO>    [default: customized] [possible values: middleware, auth-basic-
                                 proto, customized]
    -V, --version                Print version information

flight-test-integration-server

❯ cargo run --features=cli -q --bin flight-test-integration-server -- -h
arrow-integration-testing 8.0.0
Apache Arrow <[email protected]>
rust flight-test-integration-server

USAGE:
    flight-test-integration-server [OPTIONS] --port <PORT>

OPTIONS:
    -h, --help                   Print help information
        --port <PORT>
        --scenario <SCENARIO>    [default: customized] [possible values: middleware, auth-basic-
                                 proto, customized]
    -V, --version                Print version information

@github-actions github-actions bot added the parquet Changes to the parquet crate label Feb 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022 •
edited
Loading

Codecov Report

Merging #1261 (f87e2f9) into master (91d12ec) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1261      +/-   ##
==========================================
+ Coverage   82.94%   82.97%   +0.03%     
==========================================
  Files         180      180              
  Lines       52102    52083      -19     
==========================================
+ Hits        43216    43217       +1     
+ Misses       8886     8866      -20
Impacted Files Coverage Δ
...ntegration-testing/src/bin/arrow-file-to-stream.rs 0.00% <0.00%> (ø)
...ion-testing/src/bin/arrow-json-integration-test.rs 0.00% <0.00%> (ø)
...-testing/src/bin/flight-test-integration-client.rs 0.00% <0.00%> (ø)
...-testing/src/bin/flight-test-integration-server.rs 0.00% <0.00%> (ø)
...ng/src/flight_client_scenarios/auth_basic_proto.rs 0.00% <0.00%> (ø)
...ng/src/flight_client_scenarios/integration_test.rs 0.00% <0.00%> (ø)
...-testing/src/flight_client_scenarios/middleware.rs 0.00% <0.00%> (ø)
integration-testing/src/flight_server_scenarios.rs 0.00% <0.00%> (ø)
...ng/src/flight_server_scenarios/auth_basic_proto.rs 0.00% <0.00%> (ø)
...ng/src/flight_server_scenarios/integration_test.rs 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d12ec...f87e2f9. Read the comment docs.

@jimexist jimexist force-pushed the upgrade-clap branch 2 times, most recently from 0245900 to cc357b6 Compare February 2, 2022 09:45
alamb
alamb approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimexist

rustfmt.toml Outdated
@@ -16,7 +16,6 @@
# under the License.

edition = "2021"
rust-version = "1.57"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb changed the title Upgrade clap Upgrade clap to 3.0.0 Feb 2, 2022
@jimexist jimexist force-pushed the upgrade-clap branch 3 times, most recently from d16bec4 to f87e2f9 Compare February 2, 2022 16:09
@jimexist jimexist merged commit 43299cc into master Feb 3, 2022
@alamb alamb deleted the upgrade-clap branch February 3, 2022 11:49
@alamb
Copy link
Contributor

alamb commented Feb 3, 2022

🎉

@alamb
Copy link
Contributor

alamb commented Feb 3, 2022

Thanks for keeping at it @jimexist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@houqp houqp Awaiting requested review from houqp

@jorgecarleitao jorgecarleitao Awaiting requested review from jorgecarleitao

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimexist @codecov-commenter @alamb